Skip to content

[WIP] -Zhigher-ranked-assumptions-v2#155887

Draft
BoxyUwU wants to merge 30 commits intorust-lang:mainfrom
BoxyUwU:higher_ranked_assumptions_v2
Draft

[WIP] -Zhigher-ranked-assumptions-v2#155887
BoxyUwU wants to merge 30 commits intorust-lang:mainfrom
BoxyUwU:higher_ranked_assumptions_v2

Conversation

@BoxyUwU
Copy link
Copy Markdown
Member

@BoxyUwU BoxyUwU commented Apr 27, 2026 •
edited by rustbot
Loading

View all comments

r? lcnr

cc https://rust-lang.github.io/rust-project-goals/2026/assumptions_on_binders.html I would cc a tracking issue but the project goals haven't been finalized yet ^^'

need to:

  • add tests
  • write a PR description

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Apr 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@BoxyUwU BoxyUwU force-pushed the higher_ranked_assumptions_v2 branch 2 times, most recently from 8e8c7e5 to a3098f3 Compare April 28, 2026 09:12
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@BoxyUwU BoxyUwU force-pushed the higher_ranked_assumptions_v2 branch 2 times, most recently from e24ed3d to c7de204 Compare April 28, 2026 09:33
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@BoxyUwU BoxyUwU force-pushed the higher_ranked_assumptions_v2 branch from c7de204 to 642d5dc Compare April 28, 2026 09:44
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@BoxyUwU BoxyUwU force-pushed the higher_ranked_assumptions_v2 branch from 642d5dc to aba599d Compare April 28, 2026 09:56
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@BoxyUwU BoxyUwU force-pushed the higher_ranked_assumptions_v2 branch from aba599d to 19c7f1d Compare April 28, 2026 10:15
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@BoxyUwU BoxyUwU force-pushed the higher_ranked_assumptions_v2 branch from 19c7f1d to 02a859d Compare April 28, 2026 10:22
@rust-log-analyzer

This comment has been minimized.

Sign in to view
BoxyUwU
BoxyUwU commented Apr 28, 2026
View reviewed changes
Comment thread compiler/rustc_infer/src/infer/context.rs Outdated
Comment thread compiler/rustc_infer/src/infer/mod.rs Outdated
Comment thread compiler/rustc_next_trait_solver/src/solve/eval_ctxt/mod.rs
Comment thread compiler/rustc_trait_selection/src/solve/delegate.rs
Comment thread compiler/rustc_type_ir/src/lib.rs
pub mod lang_items;
pub mod lift;
pub mod outlives;
pub mod region_constraint;
Copy link
Copy Markdown
Member Author

@BoxyUwU BoxyUwU Apr 28, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird module name

View changes since the review

Comment thread compiler/rustc_type_ir/src/region_constraint.rs
}

#[derive_where(Clone, Hash, PartialEq, Debug; I: Interner)]
pub enum RegionConstraint<I: Interner> {
Copy link
Copy Markdown
Member Author

@BoxyUwU BoxyUwU Apr 28, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird type name

View changes since the review

Comment thread compiler/rustc_type_ir/src/region_constraint.rs
}
}

fn is_and_of_leaf_constraints(&self) -> bool {
Copy link
Copy Markdown
Member Author

@BoxyUwU BoxyUwU Apr 28, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should rename these to is_canonical_and and is_canonical_or

View changes since the review

Copy link
Copy Markdown
Contributor

@lcnr lcnr Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something something "normal form"

Comment thread compiler/rustc_type_ir/src/region_constraint.rs Outdated
lcnr
lcnr reviewed Apr 29, 2026
View reviewed changes
Comment thread compiler/rustc_type_ir/src/region_constraint.rs Outdated
lcnr
lcnr reviewed Apr 29, 2026
View reviewed changes
Comment thread compiler/rustc_type_ir/src/region_constraint.rs Outdated
lcnr
lcnr reviewed Apr 29, 2026
View reviewed changes
Comment thread compiler/rustc_next_trait_solver/src/solve/eval_ctxt/mod.rs Outdated
lcnr
lcnr reviewed Apr 29, 2026
View reviewed changes
Comment thread compiler/rustc_next_trait_solver/src/solve/eval_ctxt/mod.rs Outdated
lcnr
lcnr reviewed Apr 29, 2026
View reviewed changes
Comment thread compiler/rustc_type_ir/src/infer_ctxt.rs Outdated
@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Apr 29, 2026 •
edited
Loading

not blocked on eager norm, could put all the normalization support in some temp_normalization_hack module which we then rip out once we have eager norm

@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Apr 29, 2026

pls rust-lang/rust tracking issue

lcnr
lcnr reviewed Apr 29, 2026
View reviewed changes
Comment thread compiler/rustc_infer/src/infer/outlives/obligations.rs Outdated
assert!(self.next_trait_solver());

// FIXME(-Zhigher-ranked-assumptions-v2): Implement diagnostics
let origin = SubregionOrigin::Reborrow(DUMMY_SP);
Copy link
Copy Markdown
Contributor

@lcnr lcnr Apr 29, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use def_span of the current body or what not at least

View changes since the review

@rust-bors

This comment has been minimized.

Sign in to view
@BoxyUwU BoxyUwU force-pushed the higher_ranked_assumptions_v2 branch from 02a859d to dd9d787 Compare May 1, 2026 14:07
BoxyUwU added 24 commits May 1, 2026 15:08
@BoxyUwU
s/solve/solver typo
e2007e8
@BoxyUwU
readd comments to enter_forall
2b11dd5
@BoxyUwU
FIXME for fast paths
9d6f728
@BoxyUwU
incorrect binder handling FIXME
c31f98a
@BoxyUwU
better where clause
c3e191b
@BoxyUwU
AliasTyOutlivesViaEnv
7568093
@BoxyUwU
s/solve/solver typo
f68d07c
@BoxyUwU
AliasTyOutlivesViaEnv
b77217a
@BoxyUwU
handle wf(?x) assumptions
5c5f53b
@BoxyUwU
use Assumptions::new
4d64eb3
@BoxyUwU
unreused MaxUniverse visitor
4366098
@BoxyUwU
region_assumptions_from_term
fe6a810
@BoxyUwU
s/universe assumptions/placeholder assumptions
7284693
@BoxyUwU
match not iflet
522eb7b
@BoxyUwU
x fmt
07f87d2
@BoxyUwU
make region constraints in responses be an enum of old/new style
52153f0
@BoxyUwU
eagerly_handle_placeholders return type fix
8be3f42
@BoxyUwU
eval_ctxt/solver_region_constraints.rs
c2ce7bf
@BoxyUwU
eval_ctxt/solver_region_constraints import nits
038ae08
@BoxyUwU
erased regions are cause for alarm
42dbf64
@BoxyUwU
simpler evaluation of solver region constraints
2135f41
@BoxyUwU
better diagnostics (?)
4e5e197
@BoxyUwU
better externregionconstraint thingy
2c25e21
@BoxyUwU
diagnostics finish
d4b3518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@lcnr lcnr

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BoxyUwU @rust-log-analyzer @lcnr @rustbot